Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by one error. #37

Closed
wants to merge 1 commit into from
Closed

Conversation

Zburatorul
Copy link
Collaborator

The Amazon downloader sometimes gets stuck on the first Orders page. It tries to go to "last 30 days" option of the drop-down menu, but it actually stays on the "past 3 months". Furthermore, when downloading all orders, it throws an index out of bounds error on the very last option of the drop-down list. An inspection of the code suggests this is because the counter starts at 0 but gets increased too early on line 219.

@carljm
Copy link
Collaborator

carljm commented Jan 18, 2021

Sorry, I introduced this bug in #32. I just fixed it in #38, before I noticed this PR.

@jbms
Copy link
Owner

jbms commented Mar 15, 2021

Thanks, fixed by #38.

@jbms jbms closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants