Add order_groups option to Amazon scraper #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have Amazon orders going back years, and scraping all of them on every update takes forever and is flaky just due to the likelihood that something will timeout along the way when making that many requests. Once I've scraped the old ones, no new invoices are going to be added in a previous year, so assuming I update at least every 3 months, I'm really fine just scraping the 'past 3 months' order group. This adds a flexible option to specify exactly which order groups should be scraped; others will be skipped.
|
Hi @jbms, any thoughts on whether this addition makes sense? If you have other ideas for how to handle this, I'm open to implementing something different. |
|
Thanks! |
This was referenced Jan 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have Amazon orders going back years, and scraping all of those order
list pages on every update takes forever and is flaky just due to the likelihood
that something will timeout along the way when making that many requests.
Once I've scraped the old ones, no new invoices are going to be added in
the past, so e.g. assuming I update at least every 3 months, I'm really fine
just scraping the 'past 3 months' order group.
This adds a flexible option to specify exactly which order groups should
be scraped; all others will be skipped.