perf(jqLite): avoid repeated add/removeAttribute in jqLiteRemoveClass

Fixes angular#16078 Closes angular#16131
jbedard · Aug 3, 2017 · 32ee5a5 · 32ee5a5
1 parent 3650723
commit 32ee5a5
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -420,13 +420,15 @@ function jqLiteHasClass(element, selector) {
 
 function jqLiteRemoveClass(element, cssClasses) {
   if (cssClasses && element.setAttribute) {
+    var existingClasses = (' ' + (element.getAttribute('class') || '') + ' ')
+                            .replace(/[\n\t]/g, ' ');
+
     forEach(cssClasses.split(' '), function(cssClass) {
-      element.setAttribute('class', trim(
-          (' ' + (element.getAttribute('class') || '') + ' ')
-          .replace(/[\n\t]/g, ' ')
-          .replace(' ' + trim(cssClass) + ' ', ' '))
-      );
+      cssClass = trim(cssClass);
+      existingClasses = existingClasses.replace(' ' + cssClass + ' ', ' ');
     });
+
+    element.setAttribute('class', trim(existingClasses));
   }
 }