This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Improve jqLiteRemoveClass performance #16078
Labels
Milestone
Comments
aresn
changed the title
Improve jgLiteRemoveClass performance
Improve jqLiteRemoveClass performance
Jun 30, 2017
Hi, perf improvements are definitely welcome, although I wonder if you specifically experienced perf problems related to removeClass in your apps? |
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Jul 26, 2017
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Jul 27, 2017
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Jul 27, 2017
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Aug 3, 2017
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Aug 9, 2017
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Sep 9, 2017
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Sep 10, 2017
jbedard
added a commit
to jbedard/angular.js
that referenced
this issue
Sep 12, 2017
Narretz
pushed a commit
that referenced
this issue
Nov 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I would like to propose a slight modification to jqLiteRemoveClass function to increase it's performance.
Current implementation constantly reads the "class" value from DOM and writes it back to the DOM inside a for loop.
Here is what I have created for our local branch of angular:
Here is a link to a jsPerf that I have created that compares the two functions :
https://jsperf.com/compare-angular-remove-class-with-improved-version/1
The text was updated successfully, but these errors were encountered: