Use dots animation in certain Windows shells that support it #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you very much for contributing @MLoughry (and sorry for the late response) 🎉! These Windows improvements are great, loved them!
I added some nit comments, could you please review them? After that we should be ready to merge!
utils.js
Outdated
| @@ -47,8 +47,8 @@ function colorOptions({ color, succeedColor, failColor, spinnerColor }) { | |||
| } | |||
|
|
|||
| function prefixOptions({ succeedPrefix, failPrefix }) { | |||
| succeedPrefix = succeedPrefix ? succeedPrefix : (process.platform === 'win32' ? '√' : '✓'); | |||
| failPrefix = failPrefix ? failPrefix : (process.platform === 'win32' ? '×' : '✖'); | |||
| succeedPrefix = succeedPrefix ? succeedPrefix : (!terminalSupportsUnicode() ? '√' : '✓'); | |||
There was a problem hiding this comment.
Do you think we can refactor this function a bit? Having nested ternary operators can be a bit confusing to understand
We can do something like:
if(terminalSupportUnicode()) {
succeedPrefix = succeedPrefix || '✓';
failPrefix = failPrefix || '✖';
} else {
succeedPrefix = succeedPrefix || '√';
failPrefix = failPrefix || '×';
}I think it's easier to understand. It's not a blocker though 🙂.
Co-Authored-By: Juan Bautista Carpanelli <[email protected]>
Co-Authored-By: Juan Bautista Carpanelli <[email protected]>
Co-Authored-By: Juan Bautista Carpanelli <[email protected]>
|
I've just pushed a minor fix to your branch. To master it goes! thanks again for contributing! 🚢 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the inegrated terminal in VSCode, as well as the new Windows Terminal (currently in preview) support the Unicode characters used in the
dotsanimation.This change refactors the platform check to a separate function, and checks environment variables set by VSCode ( microsoft/vscode#29426 ) and Windows Terminal ( microsoft/terminal#1040 )