Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TERM_PROGRAM environment variable on integrated shell #29426

Closed
nonylene opened this issue Jun 26, 2017 · 0 comments · Fixed by #30346
Closed

Set TERM_PROGRAM environment variable on integrated shell #29426

nonylene opened this issue Jun 26, 2017 · 0 comments · Fixed by #30346
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2017

Comments

@nonylene
Copy link

  • VSCode Version: 1.13.1
  • OS Version: macOS 10.12.5

Steps to Reproduce:

  1. Launch VSCode from launcher and integrated shell.
  2. TERM_PROGRAM is not set.
  3. Launch VSCode within iTerm2.app by code command and open integrated shell.
  4. TERM_PROGRAM is set as iTerm.app

I change shell behavior by terminal applications. I set tmux to be launched only if TERM_PROGRAM equals iTerm.app.

VSCode does not set that environment variable however. TERM_PROGRAM is affected by applications launching VSCode.

Please set TERMINAL_PROGRAM variable like vscode, or add preference for environment variables on integrated shell :)

Related issue: #23295
@vscodebot vscodebot bot added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Jun 26, 2017
@Tyriar Tyriar added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Jun 26, 2017
@Tyriar Tyriar added this to the July 2017 milestone Jun 26, 2017
@Tyriar Tyriar modified the milestones: Backlog, July 2017 Jul 7, 2017
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jul 7, 2017
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 10, 2017
@mjbvz
Set TERM_PROGRAM in terminal
a01823b 
Fixes microsoft#29426

Sets the TERM_PROGRAM and TERM_PROGRAM_VERSION environment variables for the integrated terminal
@mjbvz mjbvz mentioned this issue Jul 10, 2017
Merged
@mjbvz mjbvz modified the milestones: July 2017, Backlog Jul 10, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Jul 10, 2017
mjbvz added a commit that referenced this issue Jul 10, 2017
@mjbvz
Set TERM_PROGRAM in terminal (#30346)
9c82ae8 
* Set TERM_PROGRAM in terminal

Fixes #29426

Sets the TERM_PROGRAM and TERM_PROGRAM_VERSION environment variables for the integrated terminal

* Use constant name for TERM_PROGRAM
@roblourens roblourens added the verified Verification succeeded label Aug 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2017
Development

Successfully merging a pull request may close this issue.

Set TERM_PROGRAM in terminal mjbvz/vscode
4 participants
@roblourens @Tyriar @nonylene @mjbvz