Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing plugin templates to manifest #584

Conversation

jpaniagualaconich
Copy link
Contributor

Description

Plugins come with their own templates dir which has to be included in MANIFEST.in

Motivation and Context

Fixes #583

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jpaniagualaconich jpaniagualaconich changed the title Added missing plugin templates to manifest (#583) Added missing plugin templates to manifest Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #584 (feac861) into master (74221c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          74       74           
  Lines        3194     3194           
  Branches      359      359           
=======================================
  Hits         3053     3053           
  Misses        112      112           
  Partials       29       29           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jpaniagualaconich jpaniagualaconich force-pushed the add-missing-plugin-templates-to-manifest branch from bb2fac7 to 8928859 Compare January 23, 2023 10:32
@claudep
Copy link
Contributor

claudep commented Jan 23, 2023

Thanks! If you add Fixed #583 or Fixes #583 somewhere in the commit message, the related issue will be automatically closed when this is merged.

@jpaniagualaconich jpaniagualaconich force-pushed the add-missing-plugin-templates-to-manifest branch from 8928859 to feac861 Compare January 23, 2023 13:38
@jpaniagualaconich
Copy link
Contributor Author

@claudep ok, added.

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@claudep claudep merged commit 961549d into jazzband:master Jan 23, 2023
@jpaniagualaconich jpaniagualaconich deleted the add-missing-plugin-templates-to-manifest branch September 10, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webauthn templates missing on pypi for version 1.15.0
2 participants