Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webauthn templates missing on pypi for version 1.15.0 #583

Closed
tzetter opened this issue Jan 20, 2023 · 10 comments · Fixed by #584
Closed

Webauthn templates missing on pypi for version 1.15.0 #583

tzetter opened this issue Jan 20, 2023 · 10 comments · Fixed by #584

Comments

@tzetter
Copy link

tzetter commented Jan 20, 2023

When installing version 1.15.0 of the package from pypi the two webauthn plugin JavaScript template files (https://github.com/jazzband/django-two-factor-auth/tree/1.15.0/two_factor/plugins/webauthn/templates/two_factor_webauthn) are missing.

Expected Behavior

The CreateCredentialJS and GetCredentialJS views should use the templates for generating JavaScript used by the app.

Current Behavior

As the files are missing from the package the views return error 500s. The super nice new Webauthn functionality does therefore not work.

Possible Solution

You most likely need to publish a new version of the package with the missing files included.

Your Environment

  • Python version: 3.11.1
  • Django version: 4.1.5
  • django-otp version: 1.1.4
  • django-two-factor-auth version: 1.15.0
@claudep
Copy link
Contributor

claudep commented Jan 20, 2023

Thanks for reporting. Maybe a missing entry in MANIFEST.in?

@jpaniagualaconich, could you have a look?

jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Jan 23, 2023
@jpaniagualaconich
Copy link
Contributor

oopsie, you're right @tzetter
@claudep this should fix it (plus version bump everywhere... I updated CHANGELOG assuming it'll be 1.15.1)

jpaniagualaconich added a commit to jpaniagualaconich/django-two-factor-auth that referenced this issue Jan 23, 2023
@hansegucker
Copy link
Member

Hey, thanks for fixing this. Will there be an upload soon?

@claudep
Copy link
Contributor

claudep commented Jan 28, 2023

I hoped to also include updated translations. But for now, only French made progress on them.

@Natureshadow
Copy link

Natureshadow commented Jan 28, 2023 via email

@claudep
Copy link
Contributor

claudep commented Jan 28, 2023

If some good soul happens to approve PR #588, it will mean that a release may happen very soon after.

@Natureshadow
Copy link

Can we get this bugfix released instead of holding it back until someone verifies the French translation?

@claudep
Copy link
Contributor

claudep commented Feb 13, 2023

Nothing will happen in this package until someone steps up to help maintain it.

@Natureshadow
Copy link

Natureshadow commented Feb 13, 2023 via email

@claudep
Copy link
Contributor

claudep commented Feb 14, 2023

A general help of maintainership, that is triaging, reviewing, possibly coding at times. It requires joining the Jazzband team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants