-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webauthn templates missing on pypi for version 1.15.0 #583
Comments
Thanks for reporting. Maybe a missing entry in MANIFEST.in? @jpaniagualaconich, could you have a look? |
Hey, thanks for fixing this. Will there be an upload soon? |
I hoped to also include updated translations. But for now, only French made progress on them. |
I hoped to also include updated translations. But for now, only French made progress on them.
Is this supposed to mean "I will release now anyway", or "this critical fix will continue waiting for translations"?
|
If some good soul happens to approve PR #588, it will mean that a release may happen very soon after. |
Can we get this bugfix released instead of holding it back until someone verifies the French translation? |
Nothing will happen in this package until someone steps up to help maintain it. |
Nothing will happen in this package until someone steps up to help maintain it.
What help is needed, that does not require speaking a foreign language?
|
A general help of maintainership, that is triaging, reviewing, possibly coding at times. It requires joining the Jazzband team. |
When installing version 1.15.0 of the package from pypi the two webauthn plugin JavaScript template files (https://github.com/jazzband/django-two-factor-auth/tree/1.15.0/two_factor/plugins/webauthn/templates/two_factor_webauthn) are missing.
Expected Behavior
The
CreateCredentialJS
andGetCredentialJS
views should use the templates for generating JavaScript used by the app.Current Behavior
As the files are missing from the package the views return error 500s. The super nice new Webauthn functionality does therefore not work.
Possible Solution
You most likely need to publish a new version of the package with the missing files included.
Your Environment
The text was updated successfully, but these errors were encountered: