memory: topology: expose per-numa memory #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ffromani
force-pushed
the
numa-memory-info
branch
from
df10a08 to
9c86f7a
Compare
jaypipes
reviewed
Aug 27, 2021
|
Thanks for your early feedback @jaypipes ! you raise very valid points and this is totally consider moving forward. At very least I'll most likely remove the hugepage portion from this PR - it wasn't requested by the issue I'm trying to fix anyway. |
ffromani
force-pushed
the
numa-memory-info
branch
from
0ecf508 to
34b1055
Compare
ffromani
force-pushed
the
numa-memory-info
branch
3 times, most recently
from
2e702ed to
8f0a67d
Compare
ffromani
changed the title
|
@jaypipes I think this PR is ready for another round of review. I removed all the hugepage reporting (it was at very least too premature, sorry for the noise) and fixed the pending items I had. |
ffromani
force-pushed
the
numa-memory-info
branch
from
8f0a67d to
21d2581
Compare
ffromani
force-pushed
the
numa-memory-info
branch
from
2537b76 to
2b03367
Compare
|
@jaypipes - not urgent at all, but I think this PR is ready for review, so just keeping it on our radar |
jaypipes
reviewed
Nov 1, 2021
This patch wants to add memory informations on topology.Node, so we can have per-NUMA-zone memory information. In order to do so, we extract a `memory.Area` struct from `memory.Info` to describe the basic properties of a memory zone, and we add it to `topology.Node`. In the future, we may want to add (or move) more fields to this basic building block, and we will get them for free in both system-wide and per-numa memory info. Fixes: jaypipes#200 Signed-off-by: Francesco Romani <[email protected]>
We can use `ctx.Warn` instead of raw calls to Fprintf. This patch does that in order to make the code base more regular. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
numa-memory-info
branch
from
2b03367 to
713a8e2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch wants to add memory informations on topology.Node,
so we can have per-NUMA-zone memory information.
WIP: tests are broken (and more needs to come), doc is missing,
API is provisional. The basic concepts are there, though.
Signed-off-by: Francesco Romani [email protected]