Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUMA memory info #200

Closed
chabbimilind opened this issue Oct 26, 2020 · 2 comments
Closed

NUMA memory info #200

chabbimilind opened this issue Oct 26, 2020 · 2 comments
Milestone

Comments

@chabbimilind
Copy link

The Node structure does not include per NUMA node physical memory statistics.

type Node struct {
	ID     int                  `json:"id"`
	Cores  []*cpu.ProcessorCore `json:"cores"`
	Caches []*memory.Cache      `json:"caches"`
}

Can we add Memory []*memory.Info field to the struct and provide per-NUMA-node memory stats?

On Linux, /sys/devices/system/node/node*/meminfo file will offer the necessary data.
We need to augment pkg/memory/memory_linux.go with a function such as MemoryForNode() and call it from func topologyNodes in pkg/topology/topology_linux.go.

@ffromani
Copy link
Collaborator

I'd happy to work in this area in the coming days/weeks.

@ffromani ffromani added this to the v1.0.0 milestone May 25, 2021
@ffromani
Copy link
Collaborator

begun working on a PR to fix this issue, but we're at the every early stages: #268

ffromani added a commit to ffromani/ghw that referenced this issue Aug 27, 2021
This patch wants to add memory informations on topology.Node,
so we can have per-NUMA-zone memory information.

WIP:
- do we need more tests?
- doc is missing,
- API is provisional, names to be reviewed.

The basic concepts are there, though.

Fixes: jaypipes#200
Signed-off-by: Francesco Romani <[email protected]>
ffromani added a commit to ffromani/ghw that referenced this issue Sep 13, 2021
This patch wants to add memory informations on topology.Node,
so we can have per-NUMA-zone memory information.

WIP:
- do we need more tests?
- API is provisional, names to be reviewed.

The basic concepts are there, though.

Fixes: jaypipes#200
Signed-off-by: Francesco Romani <[email protected]>
ffromani added a commit to ffromani/ghw that referenced this issue Sep 13, 2021
This patch wants to add memory informations on topology.Node,
so we can have per-NUMA-zone memory information.

WIP:
- do we need more tests?
- API is provisional, names to be reviewed.

The basic concepts are there, though.

Fixes: jaypipes#200
Signed-off-by: Francesco Romani <[email protected]>
ffromani added a commit to ffromani/ghw that referenced this issue Sep 13, 2021
This patch wants to add memory informations on topology.Node,
so we can have per-NUMA-zone memory information.
In order to do so, we extract a `memory.Area` struct from `memory.Info`
to describe the basic properties of a memory zone, and
we add it to `topology.Node`.
In the future, we may want to add (or move) more fields
to this basic building block, and we will get them for free
in both system-wide and per-numa memory info.

Fixes: jaypipes#200
Signed-off-by: Francesco Romani <[email protected]>
ffromani added a commit to ffromani/ghw that referenced this issue Sep 13, 2021
This patch wants to add memory informations on topology.Node,
so we can have per-NUMA-zone memory information.
In order to do so, we extract a `memory.Area` struct from `memory.Info`
to describe the basic properties of a memory zone, and
we add it to `topology.Node`.
In the future, we may want to add (or move) more fields
to this basic building block, and we will get them for free
in both system-wide and per-numa memory info.

Fixes: jaypipes#200
Signed-off-by: Francesco Romani <[email protected]>
ffromani added a commit to ffromani/ghw that referenced this issue Oct 27, 2021
This patch wants to add memory informations on topology.Node,
so we can have per-NUMA-zone memory information.
In order to do so, we extract a `memory.Area` struct from `memory.Info`
to describe the basic properties of a memory zone, and
we add it to `topology.Node`.
In the future, we may want to add (or move) more fields
to this basic building block, and we will get them for free
in both system-wide and per-numa memory info.

Fixes: jaypipes#200
Signed-off-by: Francesco Romani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants