Switching from AsyncStorage to react-native-async-storage (based on #54) #55
+4,894
−4,112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive beacause of incorrect peer dependencies.
|
@jasonmerino @mikerodham forget to let you know that this should be done now (based on #54) |
|
Awesome stuff pal, I've been absolutely rammed so haven't had a chance. Glad you were able to look at and get sorted though. Nice work! |
|
Thanks for your work @oas |
jasonmerino
reviewed
May 2, 2019
|
@jasonmerino this able to go ahead pal? |
|
Any news to merge MR please ? :) |
|
Will there be a new 2.0.0 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from AsyncStorage to
react-native-async-storageseems to be more difficult than expected.react-native-async-storageis not working with the React Native version used in this project -> We need to update React Native.I'm still not quite finished, i'll do the rest tomorrow 👍