-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with react native 0.59.4 #54
Comments
That's because asyncstorage is no longer a part of the core react-native. This was announced in the app as a yellowbox warning. You can see here. You may have to install this package to get it working. |
Hey everyone. Sorry for the delay here. This has been on my radar and it looks like the time to fix this is here. I'm pretty slammed right now, would any of you be able to put together a PR with the changes needed. From what I can see, all that's needed is to change where we import AsyncStorage from in the index file here and update/add peer dependencies in the package.json so when installing it will complain if you try and install the current version with a new version of React Native. Also, some documentation about which version of simple store works with which version of React Native would be good to add to the README. If no one can get to this right away I can try and carve out some time in the next month or so. |
If no one else already started, I can make the necessary changes tomorrow :) |
I am slammed at work, may have some time over the weekend to get this looked at and sorted @oas but otherwise go ahead pal. |
warning async storage has been extracted from react-native core I am leaving you guys, https://www.npmjs.com/package/@react-native-community/async-storage See you ;) |
I find this package very simple and efficient. It will be perfect if they manage to 0.59.4 |
I find this package very simple and efficient. It will be perfect if they manage to 0.59.4 |
…) (#55) * Updated react native dependencies. * Updated babel dependencies. Removed the caret from react and react-native beacause of incorrect peer dependencies. * Changed from .babelrc to babel.config.js (based on facebook/react-native#21075). * Add mock prefix to allow out of scope referencing (jestjs/jest#2567) * Mock the async-storage module. * Added explanation to README. * Changed version to 2.0.0 as it is a breaking change.
Version 2.0.0 has been released. This was resolved by #55. |
update my project to 0.59.4 and now fails
The text was updated successfully, but these errors were encountered: