Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the default report configuration, using fallback instead #67

Merged
merged 3 commits into from
Mar 10, 2016

Conversation

mauricioborges
Copy link
Contributor

Hi there,

I've opened jasmine/jasmine#1009 in jasmine-core to allow configuring a fallback report in case there's no report configured. It would allow configuring a reporter in a helper as follows:

jasmine.getEnv().addReporter(myReporter);

It would deal with issue #66 opened by myself.

Sorry if I've missed something. Thanks and regards!

@slackersoft
Copy link
Member

There is a lot of different changes in this pull request. Please pull out the things that aren't related to the default reporter changes so they can be reviewed and merged independently.

I have to think a bit more about giving jasmine-core a concept of a default reporter.

@mauricioborges
Copy link
Contributor Author

Sorry for that. My mistake while rebasing. Already fixed
On Feb 18, 2016 6:24 PM, "Gregg Van Hove" [email protected] wrote:

There is a lot of different changes in this pull request. Please pull out
the things that aren't related to the default reporter changes so they can
be reviewed and merged independently.

I have to think a bit more about giving jasmine-core a concept of a
default reporter.


Reply to this email directly or view it on GitHub
#67 (comment).

@mauricioborges mauricioborges force-pushed the master branch 3 times, most recently from 4028d8f to 5666a0c Compare February 22, 2016 20:28
@mauricioborges
Copy link
Contributor Author

@slackersoft are you thinking about removing the default reporter? +1 in my opinion. Actually I preferred doing this more conservative PR to avoid changing behaviour a lot.

@mauricioborges
Copy link
Contributor Author

also, the present me don't like the way the past me did this PR.

@slackersoft slackersoft merged commit 0142105 into jasmine:master Mar 10, 2016
slackersoft pushed a commit that referenced this pull request Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants