Adds checking to avoid issues when fallback reporter is unavailable

jasmine · Feb 22, 2016 · 5666a0c · 5666a0c
1 parent 228ca55
commit 5666a0c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/jasmine.js b/lib/jasmine.js
@@ -45,7 +45,12 @@ Jasmine.prototype.addReporter = function(reporter) {
 };
 
 Jasmine.prototype.provideFallbackReporter = function(reporter) {
-  this.env.provideFallbackReporter(reporter);
+  var reportHandler = this.env.addReporter;
+  if (this.env.provideFallbackReporter) {
+    reportHandler = this.env.provideFallbackReporter;
+  }
+  reportHandler(reporter);
+  this.defaultReporterAdded = true;
 };
 
 Jasmine.prototype.configureDefaultReporter = function(options) {
@@ -61,7 +66,6 @@ Jasmine.prototype.configureDefaultReporter = function(options) {
   }
   var consoleReporter = new module.exports.ConsoleReporter(options);
   this.provideFallbackReporter(consoleReporter);
-  this.defaultReporterAdded = true;
 };
 
 Jasmine.prototype.addMatchers = function(matchers) {

diff --git a/spec/jasmine_spec.js b/spec/jasmine_spec.js
@@ -253,7 +253,6 @@ describe('Jasmine', function() {
     it('adds a default reporter as a fallback reporter', function() {
       this.testJasmine.addReporter(new Jasmine.ConsoleReporter({}));
 
-      //spyOn(this.testJasmine, 'configureDefaultReporter');
       spyOn(this.testJasmine, 'loadSpecs');
 
       this.testJasmine.execute();