Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call success async #3577

Merged
merged 1 commit into from
May 13, 2015
Merged

Always call success async #3577

merged 1 commit into from
May 13, 2015

Conversation

jridgewell
Copy link
Collaborator

Since the success callback is called async when model isn't new, we should always call success async.

Let's not unleash Zalgo.

@braddunbar
Copy link
Collaborator

Ok by me, though we should probably write this up in the notes. 👍

@jridgewell
Copy link
Collaborator Author

Notes?

@braddunbar
Copy link
Collaborator

Release notes. Sorry, should've been more specific! 👍

@jridgewell jridgewell mentioned this pull request Apr 23, 2015
Merged
3 tasks
@jridgewell jridgewell mentioned this pull request May 13, 2015
Closed
@jashkenas
Copy link
Owner

Seems wise.

jashkenas added a commit that referenced this pull request May 13, 2015
@jashkenas
Merge pull request #3577 from jridgewell/destroy-zalgo
4aa539d 
Always call success async
@jashkenas jashkenas merged commit 4aa539d into jashkenas:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jridgewell @braddunbar @jashkenas