Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft changelog for Backbone 1.2.0 #3285

Merged
merged 63 commits into from
May 13, 2015
Merged

Draft changelog for Backbone 1.2.0 #3285

merged 63 commits into from
May 13, 2015

Conversation

akre54
Copy link
Collaborator

@akre54 akre54 commented Aug 29, 2014

Still needs:

@akre54 akre54 force-pushed the bb-120 branch 3 times, most recently from 32408ae to 75a240b Compare August 29, 2014 16:40
<br />
<ul style="margin-top: 5px;">
<li>
Added new hooks to Views to allow key internal methods to be overriden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overridden*

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@akre54
Copy link
Collaborator Author

akre54 commented Sep 25, 2014

ping @jashkenas

@akre54 akre54 force-pushed the bb-120 branch 3 times, most recently from 65f6706 to 2f3b6ed Compare September 25, 2014 19:44
@EnzoMartin
Copy link

Any chance of this going through sometime soon-ish?

@jashkenas
Copy link
Owner

Sure, but we shouldn't need a ticket for this.

@samccone
Copy link

Hey @akre54 do you think it would be possible to get a detailed breaking changelog for this release between .1 and .2 so that I can help people migrate their apps or at least point them to the official source.

Would ease the transition a bunch on Marionette side as well. 👍

jisaacks and others added 10 commits January 22, 2015 17:38
This allows you to do things like

```javascript
mycollection.at(-2) // get second to last, etc.
```
line 14 readme missing the word "with":
Backbone supplies structure to JavaScript-heavy applications by providing models key-value binding and custom events, collections...
--> on backbonejs.org reads as -->
Backbone.js gives structure to web applications by providing models with key-value binding and custom events, collections...

Also bolded models, views and collections just as they are on backbonejs.org
Fixed comment in backbone.js
Conflicts:
	index.html
@akre54
Copy link
Collaborator Author

akre54 commented Mar 20, 2015

I'd like to see us figure out the deal with #3421, #3038 et al before release, but otherwise I think we're good to go. @jridgewell @megawac anything else from you guys?

@megawac
Copy link
Collaborator

megawac commented Mar 20, 2015

Hmm, just want to run the test suites of dependents on the new version - did anyone ever look into the VirtualCollection issue I mentioned

@akre54
Copy link
Collaborator Author

akre54 commented Mar 20, 2015

No but maybe @p3drosola could chime in. What's busted specifically?

@jashkenas
Copy link
Owner

There you go — I closed those two tickets.

@p3drosola
Copy link

Hey @megawac @akre54, I just got the mention. Happy to take a look at it. Gimme a minute.

@megawac
Copy link
Collaborator

megawac commented Mar 20, 2015

What about #3528

@p3drosola
Copy link

VirtualCollection is now passing properly. thanks for the heads up 🎩

@megawac
Copy link
Collaborator

megawac commented Mar 25, 2015

Thanks @p3drosola I think this is almost good to go

@jridgewell
Copy link
Collaborator

One last need: #3529

@EnzoMartin
Copy link

So close now \o/

@akre54
Copy link
Collaborator Author

akre54 commented Apr 16, 2015

@joshuabambrick
Copy link

Updated #3207 in order to use a local version of comparator, so wouldn't need to wait for underscore.js update (could implement a patch in future if that method becomes available). Could consider renaming to binarySearch or something like sortedIndexOf, but that is probably not a huge issue.

@jridgewell
Copy link
Collaborator

Ping @akre54: Mind including #3577 in the notes as well?

@akre54
Copy link
Collaborator Author

akre54 commented Apr 23, 2015

Will do once it gets merged. In the meantime want to open a pull against my
fork with the changelog addition?

On Thu, Apr 23, 2015 at 2:17 PM, Justin Ridgewell [email protected]
wrote:

Ping @akre54 https://github.com/akre54: Mind including #3577
#3577 in the notes as well?


Reply to this email directly or view it on GitHub
#3285 (comment).

@akre54
Copy link
Collaborator Author

akre54 commented May 13, 2015

We haven't had any major activity in weeks, I think this is good to go. @jashkenas

@jashkenas
Copy link
Owner

Cool. Today's the day then.

@jridgewell
Copy link
Collaborator

Can we merge #3577 in as well?

@akre54
Copy link
Collaborator Author

akre54 commented May 13, 2015

Hallelujah!

@jridgewell jridgewell mentioned this pull request May 13, 2015
jashkenas added a commit that referenced this pull request May 13, 2015
Draft changelog for Backbone 1.2.0
@jashkenas jashkenas merged commit 683aa77 into jashkenas:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.