-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft changelog for Backbone 1.2.0 #3285
Conversation
32408ae
to
75a240b
Compare
<br /> | ||
<ul style="margin-top: 5px;"> | ||
<li> | ||
Added new hooks to Views to allow key internal methods to be overriden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overridden*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
9abbff7
to
7be54c5
Compare
ping @jashkenas |
65f6706
to
2f3b6ed
Compare
Any chance of this going through sometime soon-ish? |
Sure, but we shouldn't need a ticket for this. |
Hey @akre54 do you think it would be possible to get a detailed breaking changelog for this release between .1 and .2 so that I can help people migrate their apps or at least point them to the official source. Would ease the transition a bunch on Marionette side as well. 👍 |
This allows you to do things like ```javascript mycollection.at(-2) // get second to last, etc. ```
line 14 readme missing the word "with": Backbone supplies structure to JavaScript-heavy applications by providing models key-value binding and custom events, collections... --> on backbonejs.org reads as --> Backbone.js gives structure to web applications by providing models with key-value binding and custom events, collections... Also bolded models, views and collections just as they are on backbonejs.org
Fixed comment in backbone.js
…he same object as passed in.
Conflicts: index.html
I'd like to see us figure out the deal with #3421, #3038 et al before release, but otherwise I think we're good to go. @jridgewell @megawac anything else from you guys? |
Hmm, just want to run the test suites of dependents on the new version - did anyone ever look into the |
No but maybe @p3drosola could chime in. What's busted specifically? |
There you go — I closed those two tickets. |
What about #3528 |
VirtualCollection is now passing properly. thanks for the heads up 🎩 |
Thanks @p3drosola I think this is almost good to go |
One last need: #3529 |
So close now \o/ |
@jashkenas can we get a resolution on
|
Updated #3207 in order to use a local version of |
Will do once it gets merged. In the meantime want to open a pull against my On Thu, Apr 23, 2015 at 2:17 PM, Justin Ridgewell [email protected]
|
We haven't had any major activity in weeks, I think this is good to go. @jashkenas |
Cool. Today's the day then. |
Can we merge #3577 in as well? |
Hallelujah! |
Draft changelog for Backbone 1.2.0
Still needs:
Model::matches
as special-cased proxy to_.matches
#3307 is merged