Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reminder: Upgrade keycloak client once Backstage supports ESM #47

Closed
4 tasks
tumido opened this issue Dec 12, 2022 · 4 comments
Closed
4 tasks

Reminder: Upgrade keycloak client once Backstage supports ESM #47

tumido opened this issue Dec 12, 2022 · 4 comments
Labels
kind/dependency Pull requests that update a dependency file plugin/keycloak upstream

Comments

@tumido
Copy link
Member

tumido commented Dec 12, 2022 •
edited
Loading

Keycloak admin client drops support for CommonJS by v19. It's ESM only, causing headaches to many folks:
keycloak/keycloak-nodejs-admin-client#523

However the decision is that they won't introduce CommonJS back. Our only hope is for Backstage to fully support ESM.

backstage/backstage#7011
backstage/backstage#8242
backstage/backstage#12218

Related:
@tumido tumido mentioned this issue Dec 12, 2022
Merged
@tumido tumido mentioned this issue Jan 5, 2023
Closed
1 task
@tumido tumido mentioned this issue Feb 27, 2023
Closed
1 task
@tumido tumido added plugin/keycloak kind/dependency Pull requests that update a dependency file labels Mar 30, 2023
mareklibra referenced this issue in mareklibra/janus-idp-backstage-plugins Apr 5, 2023
@RichardW98
Merge pull request #47 from thefrontside/pc/parse-task-label
b71825d 
split task name into friendly name
@tumido tumido mentioned this issue Jul 12, 2023
Closed
1 task
@tumido tumido mentioned this issue Oct 31, 2023
Closed
@nickboldt nickboldt mentioned this issue Nov 16, 2023
Open
ydayagi added a commit to ydayagi/backstage-plugins that referenced this issue Jan 4, 2024
@ydayagi
Merge pull request janus-idp#47 from mareklibra/FLPATH-809.Authentica…
0ea9a45 
…tion

 FLPATH-809: get the user via Identity API
@schultzp2020 schultzp2020 mentioned this issue Mar 1, 2024
Closed
@nickboldt
Copy link
Member

@davidfestal FYI

@davidfestal
Copy link
Member

davidfestal commented Mar 27, 2024 •
edited
Loading

This would also impact the Dynamic backend plugin loading feature as well, which is NodeRequire-based, and has never been tested / validated with ESM modules (direct import or transitive deps).

@renovate renovate bot mentioned this issue Apr 22, 2024
Closed
This was referenced Jul 30, 2024
Closed
Closed
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Sep 3, 2024

This issue has been closed due to the fact that the Janus community is being sunset.

For future plugin issues, please use https://github.com/backstage/community-plugins/issues

For future showcase issues, please use https://issues.redhat.com/browse/RHIDP

For more information on the sunset, see:

https://janus-idp.io/blog/2024/07/05/future-of-janus-community
https://issues.redhat.com/browse/RHIDP-3690
https://issues.redhat.com/browse/RHIDP-1018

@04kash
Copy link
Member

04kash commented Sep 3, 2024 •
edited
Loading

Closing this as the upgrading keycloak client issue is being tracked under this issue: https://issues.redhat.com/browse/RHIDP-3542

@04kash 04kash closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/dependency Pull requests that update a dependency file plugin/keycloak upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nickboldt @davidfestal @tumido @jasperchui @04kash @rhdh-bot