Merge pull request #47 from thefrontside/pc/parse-task-label

split task name into friendly name
mareklibra · Mar 14, 2023 · b71825d · b71825d
2 parents bc9d5e0 + 7e67e62
commit b71825d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/plugins/parodos/src/components/Form/Form.test.tsx b/plugins/parodos/src/components/Form/Form.test.tsx
@@ -61,10 +61,12 @@ describe('<Form />', () => {
     it('can submit the multi-step form', async () => {
       const onSubmit = jest.fn();
 
-      const { getByRole } = render(
+      const { getByRole, getByText } = render(
         <Form formSchema={formSchema} onSubmit={onSubmit} />,
       );
 
+      expect(getByText('Ad Group Work Flow Task')).toBeInTheDocument();
+
       await fireEvent.change(getByRole('textbox', { name: 'api-server' }), {
         target: { value: 'https://someurl.com' },
       });

diff --git a/plugins/parodos/src/components/layouts/FluidObjectFieldTemplate.tsx b/plugins/parodos/src/components/layouts/FluidObjectFieldTemplate.tsx
@@ -56,7 +56,8 @@ export function FluidObjectFieldTemplate<
     properties.length === 1 &&
     uiSchema?.[properties[0].content.key as string]['ui:hidden'] === true;
 
-  const showTitle = uiSchema?.['ui:show-title'];
+  // TODO: reinstate when there is a task description
+  const showTitle = false; // uiSchema?.['ui:show-title'];
 
   return (
     <>

diff --git a/plugins/parodos/src/hooks/useWorkflowDefinitionToJsonSchema.ts b/plugins/parodos/src/hooks/useWorkflowDefinitionToJsonSchema.ts
@@ -14,6 +14,7 @@ import set from 'lodash.set';
 import get from 'lodash.get';
 import { type UiSchema } from '@rjsf/core';
 import type { JsonObject } from '@backstage/types';
+import { capitalize } from '../utils/string';
 
 export function getJsonSchemaType(type: WorkFlowTaskParameterType) {
   switch (type) {
@@ -93,7 +94,11 @@ export function jsonSchemaFromWorkflowDefinition(
   for (const task of workflowDefinition.tasks) {
     const schema: Record<string, any> = {
       type: 'object',
-      title: task.name,
+      title: task.name
+        .replace(/([a-z])([A-Z])/g, '$1 $2')
+        .split(' ')
+        .map(capitalize)
+        .join(' '), // TODO: task label would be good here
       properties: {},
       required: [],
     };

diff --git a/plugins/parodos/src/utils/string.ts b/plugins/parodos/src/utils/string.ts
@@ -0,0 +1,3 @@
+export function capitalize(text: string): string {
+  return `${text.charAt(0).toUpperCase()}${text.slice(1).toLowerCase()}`;
+}