fix: app does not reload model when prompt template is updated #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 67.86%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
urmauur
approved these changes
Jan 29, 2025
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
louis-menlo
deleted the
fix/app-does-not-reload-model-on-template-update
branch
louis-menlo
added a commit
that referenced
this pull request
Feb 4, 2025
* fix: app does not reload model when prompt template is updated * chore: lint fix
louis-menlo
added a commit
that referenced
this pull request
Feb 4, 2025
* fix: app does not reload model when prompt template is updated * chore: lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR addressed an issue where users switch to a different model and then switch back to the original model. The new settings are not applied in this scenario.
Chore update:
Cortex engine version bump to 0.1.49
Fixes Issues
Self Checklist
This pull request includes several updates and improvements across different files, primarily focusing on version updates and enhancements to the
ModelDropdowncomponent.Version Updates:
CORTEX_ENGINE_VERSIONfromv0.1.46tov0.1.49inextensions/engine-management-extension/rolldown.config.mjs[1] [2].CORTEX_ENGINE_VERSIONfromv0.1.46tov0.1.49inextensions/inference-cortex-extension/rolldown.config.mjs.Enhancements to
ModelDropdownComponent:useActiveModelhook inweb/containers/ModelDropdown/index.tsx.stopModelfunction call fromuseActiveModelin theModelDropdowncomponent to stop the model when a new model is selected [1] [2].