Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: app does not reload the model when the prompt template is updated #4505

Closed
1 of 3 tasks
louis-menlo opened this issue Jan 22, 2025 · 1 comment
Closed
1 of 3 tasks
Assignees
Labels
category: model settings Inference params, presets, templates P1: important Important feature / fix type: bug Something isn't working
Milestone

Comments

@louis-menlo
Copy link
Contributor

Jan version

v0.5.14-962

Describe the Bug

During the testing phase of Deepseek R1 models, we find ourselves manually updating the model's prompt template repeatedly. When switching to a different model and then switching back, an issue arose. The model template was reset, but not applied. The model wasn't reloaded because the app perceived it as the same loaded model (with the same ID).

Steps to Reproduce

  1. Select Model A (DeepSeek R1 Qwen 1.5B), modify the chat template (<|begin▁of▁sentence|>{system_message}<|User|>{prompt}<|Assistant|><|end▁of▁sentence|><|Assistant|>).
  2. Send a message to trigger model load
  3. Select Model B (DeepSeek R1 LLama 8B), don't send any message.
  4. Switch back to Model A.
  5. See model still using the template applied above.

https://discord.com/channels/1107178041848909847/1324226875123564635/1331414647445913733

Screenshots / Logs

Image

Image

Image

What is your OS?

  • MacOS
  • Windows
  • Linux
@louis-menlo louis-menlo added the type: bug Something isn't working label Jan 22, 2025
@louis-menlo louis-menlo self-assigned this Jan 22, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Jan 22, 2025
@louis-menlo louis-menlo added this to the v0.5.15 milestone Jan 22, 2025
@louis-menlo louis-menlo added the P1: important Important feature / fix label Jan 22, 2025
@louis-menlo louis-menlo moved this from Investigating to Scheduled in Menlo Jan 22, 2025
@imtuyethan imtuyethan added the category: model settings Inference params, presets, templates label Jan 23, 2025
@louis-menlo louis-menlo moved this from Scheduled to Eng Review in Menlo Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Eng Review to QA in Menlo Jan 29, 2025
@imtuyethan
Copy link
Contributor

Fixed with Jan v0.5.15-rc5-beta

@imtuyethan imtuyethan moved this from QA to Completed in Menlo Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model settings Inference params, presets, templates P1: important Important feature / fix type: bug Something isn't working
Projects
Status: Completed
Development

No branches or pull requests

2 participants