fix: input scrolls to the bottom when set the caret to the top #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Jan 3, 2025
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Barecheck - Code coverage reportTotal: 68.61%Your code coverage diff: -0.10% ▾ Uncovered files and lines
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR fixed the issue where app force-scroll to bottom every time user set the caret to top of the long input.
This PR also added a minor engine version bump to be the same as the engine management extension.
Fixes Issues
Changes made
This pull request includes several changes across multiple files to update the engine version, fix a typo, and enhance the functionality of the
RichTextEditorcomponent. The most important changes include updating the engine version, correcting a typo in theChatInputcomponent, and adding new functionality to theRichTextEditor.Updates and fixes:
extensions/inference-cortex-extension/download.bat: UpdatedENGINE_VERSIONfrom0.1.42to0.1.43.extensions/inference-cortex-extension/download.sh: UpdatedENGINE_VERSIONfrom0.1.42to0.1.43.web/screens/Thread/ThreadCenterPanel/ChatInput/index.tsx: Corrected the typoshowAttacmentMenustoshowAttachmentMenusin multiple instances. [1] [2] [3] [4] [5] [6]Enhancements to
RichTextEditor:web/screens/Thread/ThreadCenterPanel/ChatInput/RichTextEditor.tsx: Added import forRangefromslate.web/screens/Thread/ThreadCenterPanel/ChatInput/RichTextEditor.tsx: Removed unnecessaryscrollTocall ontextareaRef.web/screens/Thread/ThreadCenterPanel/ChatInput/RichTextEditor.tsx: AddedscrollSelectionIntoViewandgetScrollParentfunctions to improve scrolling behavior when selecting text.