Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scrollable modal component #2711

Merged
merged 1 commit into from
Apr 13, 2024
Merged

fix: scrollable modal component #2711

merged 1 commit into from
Apr 13, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Apr 13, 2024

Describe Your Changes

  • fix modal component scrollable content

Testing scenario

  1. Go to Hub page
  2. Download model more than 10 example
  3. Make sure the layout modal not broken and content scrollable

Before
image

After
Screenshot 2024-04-13 at 16 45 11
Screenshot 2024-04-13 at 16 45 00

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Apr 13, 2024
@urmauur urmauur added this to the v0.4.12 milestone Apr 13, 2024
@urmauur urmauur requested review from namchuai and louis-menlo April 13, 2024 09:53
@urmauur urmauur self-assigned this Apr 13, 2024
louis-menlo
louis-menlo approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 09fcdac into dev Apr 13, 2024
9 checks passed
@urmauur urmauur deleted the fix/scrollable-modal-download branch April 13, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-menlo louis-menlo louis-menlo approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-menlo