fix: cortex chat without arguments should work #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-jan
force-pushed
the
chore/fix-model-pull
branch
from
2e4d57f to
487189e
Compare
louis-jan
force-pushed
the
chore/fix-model-pull
branch
from
487189e to
83f76e3
Compare
marknguyen1302
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
cortex chatdoes nothing without -m arg #650 - If no message is input, it should enter interactive shell mode (as shown).cortex pullpersists an incorrect model ID #649 - Due to bad model input extraction (feat: pull model yaml from hf #605), it slows down the model pull request and adds an extra branch to normal HF repositories.cortex models stop"Failed to stop models" but actually works #643 - Due to duplicate code, resolving PR conflict.Fixes Issues
Self Checklist