fix: cortex chat without arguments should work

janhq · Jun 3, 2024 · 2e4d57f · 2e4d57f
1 parent 785f621
commit 2e4d57f
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 12 deletions.
diff --git a/cortex-js/src/extensions/groq/package.json b/cortex-js/src/extensions/groq/package.json
@@ -2,7 +2,7 @@
   "name": "@janhq/groq-inference-engine",
   "productName": "Groq Inference Engine",
   "version": "1.0.0",
-  "main": "dist/index.js",
+  "main": "dist/extensions/groq/index.js",
   "type": "commonjs",
   "description": "This extension enables Groq chat completion API calls",
   "author": "Jan <[email protected]>",

diff --git a/cortex-js/src/extensions/mistral/package.json b/cortex-js/src/extensions/mistral/package.json
@@ -2,7 +2,7 @@
   "name": "@janhq/mistral-inference-engine",
   "productName": "Mistral Inference Engine",
   "version": "1.0.0",
-  "main": "dist/index.js",
+  "main": "dist/extensions/mistral/index.js",
   "type": "commonjs",
   "description": "This extension enables Mistral chat completion API calls",
   "author": "Jan <[email protected]>",

diff --git a/cortex-js/src/extensions/openai/package.json b/cortex-js/src/extensions/openai/package.json
@@ -2,7 +2,7 @@
   "name": "@janhq/openai-inference-engine",
   "productName": "OpenAI Inference Engine",
   "version": "1.0.0",
-  "main": "dist/index.js",
+  "main": "dist/extensions/openai/index.js",
   "type": "commonjs",
   "description": "This extension enables OpenAI chat completion API calls",
   "author": "Jan <[email protected]>",

diff --git a/cortex-js/src/infrastructure/commanders/chat.command.ts b/cortex-js/src/infrastructure/commanders/chat.command.ts
@@ -48,6 +48,8 @@ export class ChatCommand extends CommandRunner {
       }
     }
 
+    if (!message) options.attach = true;
+
     return this.chatCliUsecases.chat(
       modelId,
       options.threadId,

diff --git a/cortex-js/src/infrastructure/commanders/usecases/init.cli.usecases.ts b/cortex-js/src/infrastructure/commanders/usecases/init.cli.usecases.ts
@@ -10,6 +10,7 @@ import { firstValueFrom } from 'rxjs';
 import { FileManagerService } from '@/file-manager/file-manager.service';
 import { rm } from 'fs/promises';
 import { exec } from 'child_process';
+import { appPath } from '../utils/app-path';
 
 @Injectable()
 export class InitCliUsecases {
@@ -257,8 +258,8 @@ export class InitCliUsecases {
 
       exec(
         join(
-          __dirname,
-          `../../../../bin/cpuinfo${process.platform !== 'linux' ? '.exe' : ''}`,
+          appPath,
+          `bin/cpuinfo${process.platform !== 'linux' ? '.exe' : ''}`,
         ),
         (error, stdout) => {
           if (error) {

diff --git a/cortex-js/src/infrastructure/commanders/utils/app-path.ts b/cortex-js/src/infrastructure/commanders/utils/app-path.ts
@@ -0,0 +1,6 @@
+import { join } from 'path';
+
+/**
+ * Path to the root of the application.
+ */
+export const appPath = join(__dirname, '../../../../../');
diff --git a/cortex-js/src/infrastructure/providers/cortex/cortex.provider.ts b/cortex-js/src/infrastructure/providers/cortex/cortex.provider.ts
@@ -10,11 +10,6 @@ import { normalizeModelId } from '@/infrastructure/commanders/utils/normalize-mo
 import { firstValueFrom } from 'rxjs';
 import { FileManagerService } from '@/file-manager/file-manager.service';
 
-/**
- * A class that implements the InferenceExtension interface from the @janhq/core package.
- * The class provides methods for initializing and stopping a model, and for making inference requests.
- * It also subscribes to events emitted by the @janhq/core package and handles new message requests.
- */
 @Injectable()
 export default class CortexProvider extends OAIEngineExtension {
   provider: string = 'cortex';

diff --git a/cortex-js/src/infrastructure/repositories/extensions/extension.repository.ts b/cortex-js/src/infrastructure/repositories/extensions/extension.repository.ts
@@ -4,6 +4,7 @@ import { Extension } from '@/domain/abstracts/extension.abstract';
 import { readdir, lstat, access } from 'fs/promises';
 import { join } from 'path';
 import { EngineExtension } from '@/domain/abstracts/engine.abstract';
+import { appPath } from '@/infrastructure/commanders/utils/app-path';
 
 @Injectable()
 export class ExtensionRepositoryImpl implements ExtensionRepository {
@@ -36,12 +37,13 @@ export class ExtensionRepositoryImpl implements ExtensionRepository {
   }
 
   loadCoreExtensions(): void {
-    const extensionsPath = join(__dirname, './../../../extensions');
+    const extensionsPath = join(appPath, 'src', 'extensions');
     this.loadExtensions(extensionsPath);
   }
 
   loadExternalExtensions(): void {
-    const extensionsPath = process.env.EXTENSIONS_PATH ?? 'extensions';
+    const extensionsPath =
+      process.env.EXTENSIONS_PATH ?? join(appPath, 'extensions');
     this.loadExtensions(extensionsPath);
   }