Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct remaining time #1669

Merged
merged 3 commits into from
Nov 12, 2024
Merged

fix: correct remaining time #1669

merged 3 commits into from
Nov 12, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Nov 12, 2024 •
edited
Loading

Describe Your Changes

Remaining time of library sometimes does not work. Implement our own function.

image

Fixes Issues

Self Checklist

@vansangpfiev vansangpfiev marked this pull request as ready for review November 12, 2024 03:56
@vansangpfiev vansangpfiev requested a review from a team November 12, 2024 03:56
@namchuai
Copy link
Collaborator

could you please add some unit test

@vansangpfiev
Copy link
Contributor Author

could you please add some unit test

Updated.

namchuai
namchuai approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit f700ba7 into dev Nov 12, 2024
5 checks passed
@vansangpfiev vansangpfiev deleted the fix/progress-bar branch November 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai