Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: CLI cortex pull model download progress is inaccurate #1655

Closed
3 of 7 tasks
gabrielle-ong opened this issue Nov 8, 2024 · 2 comments
Closed
3 of 7 tasks

bug: CLI cortex pull model download progress is inaccurate #1655

gabrielle-ong opened this issue Nov 8, 2024 · 2 comments
Assignees
Labels
category: model management Model pull, yaml, model state type: bug Something isn't working
Milestone

Comments

@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Nov 8, 2024

Cortex version

v227 onwards

Describe the issue and expected behaviour

For cortexso models: Displays a very large percentage 2147483647, many download lines
Also encountered on Windows by Tin
Functionality: Model downloads successfully.

Huggingface models have no issue:
image

Expected behaviour:

  1. When I cortex pull a model: I see the X download bars for the X model files required
  2. The download bar accurately shows the % required

Steps to Reproduce

No response

Screenshots / Logs

image

image

What is your OS?

  • Windows
  • Mac Silicon
  • Mac Intel
  • Linux / Ubuntu

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)

Hardware Specs eg OS version, GPU

No response

@gabrielle-ong gabrielle-ong added the type: bug Something isn't working label Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Nov 8, 2024
@gabrielle-ong gabrielle-ong added the category: model management Model pull, yaml, model state label Nov 8, 2024
@gabrielle-ong gabrielle-ong moved this from Investigating to In Review in Menlo Nov 11, 2024
@gabrielle-ong gabrielle-ong moved this from In Review to Review + QA in Menlo Nov 11, 2024
@gabrielle-ong
Copy link
Contributor Author

Thanks @vansangpfiev!
The progress bar and Percent is now fixed, but the timing estimate shows X Days eg 30 days, 55 days

Image

@gabrielle-ong
Copy link
Contributor Author

Thanks @vansangpfiev!
✅ QAed on v234
Image
Image

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Nov 13, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.3 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: model management Model pull, yaml, model state type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants