Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: engine management #1546

Merged
merged 16 commits into from
Nov 5, 2024
Prev Previous commit
Next Next commit
remove v2 commands
namchuai committed Nov 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 526312a1d83253d1031a89aa4794f808d4944925
19 changes: 0 additions & 19 deletions engine/cli/command_line_parser.cc
Original file line number Diff line number Diff line change
@@ -427,25 +427,6 @@ void CommandLineParser::SetupSystemCommands() {
});
}

void CommandLineParser::EngineInstallV2(CLI::App* parent,
const std::string& engine_name) {
auto install_engine_cmd = parent->add_subcommand(engine_name, "");
install_engine_cmd->usage("Usage:\n" + commands::GetCortexBinary() +
" engines install " + engine_name + " [options]");
install_engine_cmd->group(kEngineGroup);
install_engine_cmd->callback([this, engine_name] {
if (std::exchange(executed_, true))
return;
auto result = commands::EngineReleaseCmd().Exec(
cml_data_.config.apiServerHost,
std::stoi(cml_data_.config.apiServerPort), engine_name);

if (result.has_error()) {
CLI_LOG(result.error());
}
});
}

void CommandLineParser::EngineInstall(CLI::App* parent,
const std::string& engine_name,
std::string& version, std::string& src) {