Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: engine management #1546

Merged
merged 16 commits into from
Nov 5, 2024
15 changes: 0 additions & 15 deletions engine/cli/command_line_parser.cc
Original file line number Diff line number Diff line change
@@ -326,21 +326,6 @@ void CommandLineParser::SetupEngineCommands() {
std::stoi(cml_data_.config.apiServerPort));
});

auto installv2_cmd = engines_cmd->add_subcommand("release", "Install engine");
installv2_cmd->group(kSubcommands);
installv2_cmd->callback([this, installv2_cmd] {
if (std::exchange(executed_, true))
return;
if (installv2_cmd->get_subcommands().empty()) {
CLI_LOG("[engine_name] is required\n");
CLI_LOG(installv2_cmd->help());
}
});
for (auto& engine : engine_service_.kSupportEngines) {
std::string engine_name{engine};
EngineInstallV2(installv2_cmd, engine_name);
}

auto install_cmd = engines_cmd->add_subcommand("install", "Install engine");
install_cmd->usage("Usage:\n" + commands::GetCortexBinary() +
" engines install [engine_name] [options]");
2 changes: 0 additions & 2 deletions engine/cli/command_line_parser.h
Original file line number Diff line number Diff line change
@@ -22,8 +22,6 @@ class CommandLineParser {

void SetupSystemCommands();

void EngineInstallV2(CLI::App* parent, const std::string& engine_name);

void EngineInstall(CLI::App* parent, const std::string& engine_name,
std::string& version, std::string& src);