Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove embeddings from CLI help #1543

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: remove embeddings from CLI help #1543

merged 1 commit into from
Oct 24, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 23, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

  • We don't support embeddings yet → remove it from help menu

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 23, 2024 23:29
@vansangpfiev vansangpfiev requested a review from namchuai October 23, 2024 23:29
@vansangpfiev vansangpfiev merged commit 10b64ee into dev Oct 24, 2024
8 checks passed
@vansangpfiev vansangpfiev deleted the fix/rm-embeddings branch October 24, 2024 04:30
@gabrielle-ong gabrielle-ong added type: bug Something isn't working and removed type: bug Something isn't working labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: remove embeddings from the -h menu in cortex
3 participants
@vansangpfiev @namchuai @gabrielle-ong