Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: remove embeddings from the -h menu in cortex #1541

Closed
4 of 6 tasks
vansangpfiev opened this issue Oct 23, 2024 · 1 comment · Fixed by #1543
Closed
4 of 6 tasks

bug: remove embeddings from the -h menu in cortex #1541

vansangpfiev opened this issue Oct 23, 2024 · 1 comment · Fixed by #1543
Assignees
@vansangpfiev
Labels
type: bug Something isn't working
Milestone
v1.0.2

Comments

@vansangpfiev
Copy link
Contributor

Cortex version

v1.0.1

Describe the Bug

We don't support embeddings yet, so should remove it from cortex -h

Steps to Reproduce

cortex -h

Screenshots / Logs

No response

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@vansangpfiev vansangpfiev added the type: bug Something isn't working label Oct 23, 2024
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Oct 23, 2024
@vansangpfiev vansangpfiev self-assigned this Oct 23, 2024
@vansangpfiev vansangpfiev mentioned this issue Oct 23, 2024
Merged
3 tasks
@vansangpfiev vansangpfiev moved this from Investigating to Review + QA in Menlo Oct 24, 2024
@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 25, 2024
@gabrielle-ong gabrielle-ong closed this as completed by moving to Completed in Menlo Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Completed to Review + QA in Menlo Oct 25, 2024
@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Oct 25, 2024 •
edited
Loading

Thanks @vansangpfiev! Marking complete in v198

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 25, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.2 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vansangpfiev vansangpfiev

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
v1.0.2
Development

Successfully merging a pull request may close this issue.

fix: remove embeddings from CLI help janhq/cortex.cpp
2 participants
@vansangpfiev @gabrielle-ong