Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cortex CLI should be a layer on top of the API Server #1489

Merged
merged 19 commits into from
Oct 16, 2024
Merged

fix: Cortex CLI should be a layer on top of the API Server #1489

merged 19 commits into from
Oct 16, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 15, 2024 •
edited
Loading

Describe Your Changes

  • All commands are executed by requesting API server, except cortex pull and cortex engines install (will improve in another PR)
  • Separate CLI and Server into binaries will be in another PR also
  • Remove deprecated API endpoints for swagger

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev changed the title fix: separate CLI and APIs server fix: Cortex CLI should be a layer on top of the API Server Oct 16, 2024
@vansangpfiev vansangpfiev marked this pull request as ready for review October 16, 2024 05:05
namchuai
namchuai approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 6f22aa1 into dev Oct 16, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/swagger branch October 16, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vansangpfiev @namchuai