Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planning: Cortex CLI should be a layer on top of the API Server #1492

Closed
Tracked by #1423 ...
vansangpfiev opened this issue Oct 16, 2024 · 2 comments
Closed
Tracked by #1423 ...

planning: Cortex CLI should be a layer on top of the API Server #1492

vansangpfiev opened this issue Oct 16, 2024 · 2 comments
Assignees
Milestone

Comments

@vansangpfiev
Copy link
Contributor

vansangpfiev commented Oct 16, 2024

Sub-ticket from Epic: #1415

Problem Statement

Cortex CLI does not use the API Server in all commands

Feature Idea

Cortex CLI should be a layer on top of the API Server.
This is quite straight forward except for cortex pull and cortex engines install.
We use libcurl UI/UX for download progress for above CLI commands and get the models, engines directly from Github, HF, ... The execution via /v1/models/pull and /v1/engines/install requires a lot of changes in UI/UX and logic (will need websockets to track download progress).
Related ticket: #1423

For cortex pull and cortex engines install using API server, can we move them into v1.0.2 instead of v1.0.1?

cc: @dan-homebrew @0xSage @gabrielle-ong @namchuai @nguyenhoangthuan99

@vansangpfiev
Copy link
Contributor Author

Another thing: because CLI is a layer on top of the API server, CLI will start the Server if it is not started, before executing any command.

@gabrielle-ong gabrielle-ong moved this from Investigating to Planning in Menlo Oct 16, 2024
@dan-menlo dan-menlo changed the title idea: Cortex CLI should be a layer on top of the API Server planning: Cortex CLI should be a layer on top of the API Server Oct 21, 2024
@gabrielle-ong gabrielle-ong moved this from Planning to Review + QA in Menlo Oct 21, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.1 milestone Oct 21, 2024
@gabrielle-ong
Copy link
Contributor

Marking as complete, as a subtask under #1415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants