Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use relative path for model information #1399

Merged
merged 10 commits into from
Oct 3, 2024
Merged

fix: use relative path for model information #1399

merged 10 commits into from
Oct 3, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

  • Use relative path for yaml file path and model files
  • In case of Import, we use relative path for yaml file and keep the model files as is

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 3, 2024 06:03
@vansangpfiev vansangpfiev changed the title fix: db rel path fix: use relative path for model information Oct 3, 2024
dan-menlo
dan-menlo approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm to unblock. Can you link corresponding issue/motivation?

@vansangpfiev
Copy link
Contributor Author

Lgtm to unblock. Can you link corresponding issue/motivation?

It is Louis's suggestion:
https://discordapp.com/channels/1107178041848909847/1204617960615055401/1290493569156776088

@vansangpfiev vansangpfiev merged commit 8657549 into dev Oct 3, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/db-rel-path branch October 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-menlo dan-menlo dan-menlo approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vansangpfiev @nguyenhoangthuan99 @dan-menlo @sangjanai