-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use relative path for model info in data folder #1368
Comments
@vansangpfiev do we have an issue tracking the edge case for import models? |
@gabrielle-ong Created a ticket for tracking: #1496 |
QA: Mac, Linux, Windows |
@vansangpfiev clarifying so I can understand this better for docs (no changes needed for v1.0.1)
Sample test (this may be entirely wrong, cmiiw)For this screenshot, I copied a new |
@gabrielle-ong This PR is intended for migrating all cortex data folder which includes |
@gabrielle-ong I think this PR isn't supposed to cover the "model import" edge case - e.g. copying a model folder in. @vansangpfiev is just updating Cortex to use relative paths instead of absolute paths. I think we can handle the import scenario in the separate ticket.
|
We store absolute path for
yaml
path in database. When we transfer the Cortex data folder (models) to another computer or move it between disks/folders, it will break.We have all model data in the data folder, it makes sense to store relative path in the database.
Note: we have an edge case for
import
modelMotivation / context: https://discordapp.com/channels/1107178041848909847/1204617960615055401/1290493569156776088
The text was updated successfully, but these errors were encountered: