Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cortex chat is a non-interactive request #1331

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: cortex chat is a non-interactive request #1331

merged 2 commits into from
Sep 25, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 25, 2024

Describe Your Changes

-m, --message is now required for cortex chat

> .\cortex-nightly.exe chat tinyllama:gguf
[model_id] and [msg] are required

Send a chat completion request
Usage:
cortex-nightly.exe chat [model_id] -m [msg]

Positionals:
  model_id TEXT

Options:
  -h,--help                   Print this help message and exit
  -m,--message TEXT           Message to chat with model

Examples:

> .\cortex-nightly.exe chat tinyllama:gguf -m "Tell me a joke"
Sure, here's a funny one for you:

A man goes to the doctor with a cough. The doctor suggests medication and prescribes a pill that will make him cough up his gold teeth.

The man is thrilled at this newfound freedom from the nuisance of dental hygiene, but as he takes the pill, he realizes it's not a solution at all. It only makes his 
teeth twist and turn in unnatural ways.

Without thinking, the man throws away the pill and heads to the bathroom where he proceeds to mangle his own teeth, causing a chain of events that leads him to lose control and scream "Umbrella! UM-BREAKING!"

The joke ends with the doctor running outside in the rain to find their umbrella has fallen apart, and the man is left as an object of ridicule, surrounded by broken 
teeth.

Hope you're having a great time with this one!

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ looks good!

@vansangpfiev vansangpfiev merged commit 44bdc65 into dev Sep 25, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/chat branch September 25, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants