Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cortex chat is a non-interactive request & should stdout to terminal #1313

Closed
4 of 6 tasks
freelerobot opened this issue Sep 23, 2024 · 1 comment
Closed
4 of 6 tasks
Assignees
Labels
P1: important Important feature / fix type: bug Something isn't working
Milestone

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Sep 23, 2024

Cortex version

v83

Describe the Bug

Right now cortex chat starts an interactive shell.
Originally, we only intended for run to start the shell.

For consistency, cortex chat should mirror the other cortex subcommands like models, engines: ping the api endpoint, and return a response within the standard terminal.

But cmiiw @dan-homebrew

Steps to Reproduce

  1. cortex start the server
  2. cortex models start ... the model
  3. cortex chat ...
  4. expected: chat request response within terminal

Screenshots / Logs

Instead, we enter an interactive chat shell.

(base) PS C:\Users\n\cortexcpp-nightly\models> cortex-nightly chat mistral -m "hello"
Inorder to exit, type `exit()`
> Hello! How can I assist you today?
>

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@freelerobot freelerobot added P1: important Important feature / fix type: bug Something isn't working labels Sep 23, 2024
@freelerobot freelerobot moved this to Planning in Menlo Sep 23, 2024
@freelerobot freelerobot changed the title bug: cortex chat is a single request & not an interactive shell bug: cortex chat is a non-interactive request & not an interactive shell Sep 24, 2024
@freelerobot freelerobot changed the title bug: cortex chat is a non-interactive request & not an interactive shell bug: cortex chat is a non-interactive request & should return to terminal Sep 24, 2024
@freelerobot freelerobot changed the title bug: cortex chat is a non-interactive request & should return to terminal bug: cortex chat is a non-interactive request & should stdout to terminal Sep 24, 2024
@dan-menlo dan-menlo added this to the v0.1.0 milestone Sep 24, 2024
@vansangpfiev vansangpfiev moved this from Planning to In Progress in Menlo Sep 24, 2024
@freelerobot
Copy link
Contributor Author

works wonderfully

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Menlo Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants