-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppx_jane doesn't work with ocamlfind #6
Comments
This works:
|
This package is merely a copy of the ppx_jane with an amended set of ppx rewriters, namely with the ppx_js_style removed, which makes it impossible to use ppx_jane (and ppx_base) especially when the code is generated, e.g., when the `findlib.dynload` library is used together with ocamlfind, which requires the inclusion of a generated code that triggers a fatal warning in ppx_js_style. We provided [a fix][1] for that, which was ignored. Another example, is code generated by various protocol compilers, namely piqi-ocaml, for which we also provided a [fix][2] that got merged but was never released. In other words, ppx_js_style is applying itself to the code that neither belongs to Jane Street nor even to a user of the ppx_jane rewriter. We have [been asking Jane Street][5] to remove ppx_js_style for a long time but we were just ignored (no replies in 5 months). Therefore we decided to create our own package with the set of ppx rewriters that we use in BAP (which also solves another issue associated with [ppx_jane][6]). Once this package is merged we can move BAP to the newest versions of OCaml, up to 4.11.1, see [the PR to BAP][5]. [1]: ocaml/ocamlfind#9 [2]: alavrik/piqi-ocaml#15 [3]: janestreet/ppx_jane#5 [4]: janestreet/ppx_jane#6 [5]: BinaryAnalysisPlatform/bap#1116
Hum, the command line contains I don't know anything about ocamlfind, so I have no idea if you should provide more flags to it, or it doesn't support this kind of stuff, or some ocamlfind metadata is incorrect. Is using dune not an option? It would surely get this right. |
Oops, sorry forgot to close it. Indeed, as @drvink pointed out, in order to link the runtime libraries the For anyone who's stumbling with this linker error the correct invocation is,
|
Here is a minimal example,
Here is the output
The text was updated successfully, but these errors were encountered: