Use let () instead of let _ for ignored value #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simply to ease use of piqi with code that may (transitively) bring in ppx_js_style, which requires explicit type annotation of ignored values: https://github.com/janestreet/ppx_js_style#-allow-unannotated-ignores
|
@drvink merged. Thank you! |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Nov 7, 2020
This package is merely a copy of the ppx_jane with an amended set of ppx rewriters, namely with the ppx_js_style removed, which makes it impossible to use ppx_jane (and ppx_base) especially when the code is generated, e.g., when the `findlib.dynload` library is used together with ocamlfind, which requires the inclusion of a generated code that triggers a fatal warning in ppx_js_style. We provided [a fix][1] for that, which was ignored. Another example, is code generated by various protocol compilers, namely piqi-ocaml, for which we also provided a [fix][2] that got merged but was never released. In other words, ppx_js_style is applying itself to the code that neither belongs to Jane Street nor even to a user of the ppx_jane rewriter. We have [been asking Jane Street][5] to remove ppx_js_style for a long time but we were just ignored (no replies in 5 months). Therefore we decided to create our own package with the set of ppx rewriters that we use in BAP (which also solves another issue associated with [ppx_jane][6]). Once this package is merged we can move BAP to the newest versions of OCaml, up to 4.11.1, see [the PR to BAP][5]. [1]: ocaml/ocamlfind#9 [2]: alavrik/piqi-ocaml#15 [3]: janestreet/ppx_jane#5 [4]: janestreet/ppx_jane#6 [5]: BinaryAnalysisPlatform/bap#1116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply to ease use of piqi with code that may (transitively) bring in
ppx_js_style, which requires explicit type annotation of ignored values:
https://github.com/janestreet/ppx_js_style#-allow-unannotated-ignores