Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audiomixerboard: Fix extra blank line when musician name length % iBreakPos == 0 #2542

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

dtinth
Copy link
Contributor

@dtinth dtinth commented Mar 23, 2022

Short description of changes
Fix a bug where a blank line is shown after some client’s name in the mixer board when their name’s length is divisible by iBreakPos (which is 8 or 4).

CHANGELOG: Client: Fix a bug where a blank line is shown after some client’s name in the mixer board in some conditions.

Context: Fixes an issue?
There is a regression introduced in Jamulus 3.8.2 by #1994 / #1993 (which fixes #1451) causing some musician’s name to have an extra blank line at the end.
image

Does this change need documentation? What needs to be documented and how?
No

Status of this Pull Request
Working fix

image

What is missing until this pull request can be merged?
N/A

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be complicated but it makes sense.

@hoffie hoffie added this to the Release 3.9.0 milestone Mar 23, 2022
@hoffie hoffie changed the title Fix extra blank line when name length % iBreakPos == 0 Audiomixerboard: Fix extra blank line when musician name length % iBreakPos == 0 Mar 23, 2022
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good and works as expected.
(I've slightly edited the commit description and therefore force-pushed. Merging now despite not all checks having finished again, but the commit content is unchanged)

@hoffie hoffie merged commit 55e74bd into jamulussoftware:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Musician name wrapping cuts through Unicode Symbols
3 participants