Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1451 - unicode in mixer should wrap on character boundaries #1993

Closed
wants to merge 2 commits into from

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented Sep 5, 2021

Short description of changes

@djfun wrote a fix but didn't raise a PR, so here's the PR.

Context: Fixes an issue?

Yes. #1451. This still happens.

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Closed in favor of #1994. Therefore:
CHANGELOG: SKIP

What is missing until this pull request can be merged?

Needs testing.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added the bug Something isn't working label Sep 5, 2021
@ann0see ann0see added this to the Release 3.8.1 milestone Sep 5, 2021
pljones added a commit to pljones/jamulus that referenced this pull request Sep 5, 2021
@pljones pljones closed this Sep 5, 2021
pljones added a commit to pljones/jamulus that referenced this pull request Sep 5, 2021
@hoffie hoffie mentioned this pull request Jan 20, 2022
8 tasks
@hoffie hoffie changed the title Fix for #1688 - unicode in mixer should wrap on character boundaries Fix for #1451 - unicode in mixer should wrap on character boundaries Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants