Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Mnemonics Keys for MacOS #1873

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Enable Mnemonics Keys for MacOS #1873

merged 1 commit into from
Jun 14, 2021

Conversation

henkdegroot
Copy link
Contributor

Fixes #1726

pljones
pljones reviewed Jun 13, 2021
View reviewed changes
src/main.cpp Show resolved Hide resolved
@henkdegroot henkdegroot force-pushed the enable-mac-mnemonics branch from 4aa7e81 to e80f7ea Compare June 13, 2021 21:01
@hoffie hoffie added this to the Release 3.8.1 milestone Jun 13, 2021
@henkdegroot henkdegroot force-pushed the enable-mac-mnemonics branch from e80f7ea to 9191bd9 Compare June 14, 2021 05:41
ann0see
ann0see approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested client on Big Sur. Works as expected. --> merge

@ann0see ann0see merged commit 77eda41 into jamulussoftware:master Jun 14, 2021
@ann0see
Copy link
Member

ann0see commented Jun 14, 2021 •
edited
Loading

CHANGELOG: Mac: Keyboard shortcuts now also work on macOS

@henkdegroot henkdegroot deleted the enable-mac-mnemonics branch June 14, 2021 20:02
@ann0see ann0see mentioned this pull request Apr 22, 2022
Closed
ann0see added a commit that referenced this pull request Apr 22, 2022
@ann0see
Document #1873 as comment
0764536 
#1873 wasn't documented in the comment.
pgScorpio pushed a commit to pgScorpio/jamulus that referenced this pull request Apr 28, 2022
@ann0see @pgScorpio
Document jamulussoftware#1873 as comment
a63eaff 
jamulussoftware#1873 wasn't documented in the comment.
ann0see added a commit to ann0see/jamulus that referenced this pull request Apr 30, 2022
@ann0see
Document jamulussoftware#1873 as comment
b0c7db4 
jamulussoftware#1873 wasn't documented in the comment.
@ann0see
Copy link
Member

ann0see commented Jun 18, 2022

@hoffie I think this PR was wrongly added to the nightly changelog...

@hoffie
Copy link
Member

hoffie commented Jun 18, 2022

Probably due to 0764536. I'll open a separate issue to avoid that.

@hoffie hoffie mentioned this pull request Jun 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ann0see ann0see ann0see approved these changes

@pljones pljones pljones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.8.1
Development

Successfully merging this pull request may close these issues.

Mac: Enable accelerator key functionality
4 participants
@henkdegroot @ann0see @hoffie @pljones