Changelog generation: Avoid false positives #2657
Milestone
Comments
hoffie
added a commit
to hoffie/jamulus
that referenced
this issue
Jun 18, 2022
… in git log Previously, all PRs from the relevant git log were added to the ChangeLog. This causes false positives when older PRs are intentionally mentioned again (e.g. for further fixes or documentation updates). At the same time, simply skipping them removes an additional method to avoid forgotten PRs. Therefore, only add git-mentioned PRs if they don't have a milestone (or a matching one). Fixes: jamulussoftware#2657
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The changelog generator added #1873 for the latest nightly, although it was already part of a previous release.
It was probably due to 0764536.
The generator looks as both Github milestones and git history. Maybe the latter should always be cross-checked to remove PRs which are properly assigned to a previous milestone.
The text was updated successfully, but these errors were encountered: