Implement Schema for nalgebra matrix type #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
jamesmunns
reviewed
Sep 29, 2024
jamesmunns
added a commit
that referenced
this pull request
Oct 15, 2024
jamesmunns
added a commit
that referenced
this pull request
Oct 15, 2024
* Start introducing postcard-schema crate * Break out impls, remove Varint * Switch up enum variants, cargo fmt * Take nalgebra changes from #175 * More cleanup of the schema crate * Correct some CI checks * Restore the rest of CI * Rev versions, prepare for partial release
|
By the way, thank you @avsaase for reporting this, it was a perfect reference for a well contained and versioned schema impl, and I used it as the basis of the new setup in #176 - I'm hoping to lower the barrier for adding arbitrary type impls. It was something I had to port over to the new crate so this PR didn't get merged, but it was definitely appreciated. |
|
Thanks for including this. And nice work on the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to send some nalgebra types over the wire using postcard-rpc so I needed to implement the
Schematrait. Initially I used a newtype to get around the orphan rule but in this case that's quite annoying because it requires copying a huge API into my own project.I figured
nalgebrais a somewhat foundational crate in the Rust ecosystem to I think it is acceptable to add it an an optional dependency here.