Browser map refactor #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mitchhentges
commented
Feb 29, 2016
mitchhentges
commented
- Adding new Linux commands is now easier, there's no data duplication :D
- Increases detection on Linux and OSX: rather than detecting each browser one-by-one, it happens in parallel. Welcome to the future.
- De-duplicates the same browser running under different command names in Linux
- Makes browser-detection manipulation easier and more testable
added 17 commits
February 28, 2016 16:06
Code reduction
Set up type and name on 'available' browser object
Add ava
|
Out of all the attempted refactors, I think that this one is the cleanest and solve the most problems. Closing the others. |
This was referenced Mar 1, 2016
Closed
Closed
|
(Super secret code review via Google Hangouts, btw) |
shhhh 😉 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.