Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor detect browser list #13

Closed
mitchhentges opened this issue Feb 27, 2016 · 2 comments
Closed

Refactor detect browser list #13

mitchhentges opened this issue Feb 27, 2016 · 2 comments

Comments

@mitchhentges
Copy link
Member

The map of browsers currently has each key represent a potential command on Linux to detect the browser. However, since different package managers call the browsers different names, there become duplicate values in the browsers map with different keys: see chromium and chromium-browser.

Instead, each key should be the browser name, and there should be an array: commands with the list of potential names for the browser name.

@mitchhentges
Copy link
Member Author

This will also remove the need for winDetectMap

@mitchhentges
Copy link
Member Author

Closed by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant