Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JAEGER_IMAGE_TAG with JAEGER_VERSION #6614

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

ADI-ROXX
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@ADI-ROXX ADI-ROXX requested a review from a team as a code owner January 26, 2025 16:58
@ADI-ROXX ADI-ROXX requested a review from pavolloffay January 26, 2025 16:58
@dosubot dosubot bot added the docker Pull requests that update Docker code label Jan 26, 2025
@ADI-ROXX
Copy link
Contributor Author

@yurishkuro There was an issue with the previous PR. By mistake I have added a commit "Return 400" for another issue that was reflected in the new branch that I was creating everytime. I have solved it now.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (6d4d7c4) to head (4fa1ae9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6614      +/-   ##
==========================================
- Coverage   96.05%   96.03%   -0.03%     
==========================================
  Files         364      364              
  Lines       20750    20750              
==========================================
- Hits        19932    19927       -5     
- Misses        622      626       +4     
- Partials      196      197       +1     
Flag Coverage Δ
badger_v1 9.88% <ø> (ø)
badger_v2 1.83% <ø> (ø)
cassandra-4.x-v1-manual 15.02% <ø> (ø)
cassandra-4.x-v2-auto 1.82% <ø> (ø)
cassandra-4.x-v2-manual 1.82% <ø> (ø)
cassandra-5.x-v1-manual 15.02% <ø> (ø)
cassandra-5.x-v2-auto 1.82% <ø> (ø)
cassandra-5.x-v2-manual 1.82% <ø> (ø)
elasticsearch-6.x-v1 19.23% <ø> (ø)
elasticsearch-7.x-v1 19.31% <ø> (ø)
elasticsearch-8.x-v1 19.48% <ø> (ø)
elasticsearch-8.x-v2 1.83% <ø> (ø)
grpc_v1 11.18% <ø> (ø)
grpc_v2 8.04% <ø> (ø)
kafka-3.x-v1 10.17% <ø> (ø)
kafka-3.x-v2 1.83% <ø> (ø)
memory_v2 1.83% <ø> (ø)
opensearch-1.x-v1 19.36% <ø> (ø)
opensearch-2.x-v1 19.36% <ø> (ø)
opensearch-2.x-v2 1.83% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.82% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 88e819e into jaegertracing:main Jan 26, 2025
56 of 57 checks passed
@yurishkuro
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize env variables used for versions in docker compose files
2 participants