Replace JAEGER_IMAGE_TAG with JAEGER_VERSION #6613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: cs-308-2023 <[email protected]>
yurishkuro
reviewed
Jan 26, 2025
| @@ -183,7 +183,7 @@ func (aH *APIHandler) transformOTLP(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| traces, err := otlp2traces(body) | |||
| if aH.handleError(w, err, http.StatusInternalServerError) { | |||
| if aH.handleError(w, err, http.StatusBadRequest) { | |||
There was a problem hiding this comment.
I'll fix it right away.
Signed-off-by: cs-308-2023 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6613 +/- ##
==========================================
- Coverage 96.23% 95.95% -0.28%
==========================================
Files 377 364 -13
Lines 21421 20750 -671
==========================================
- Hits 20614 19911 -703
- Misses 614 640 +26
- Partials 193 199 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@yurishkuro The issue in this pr is because of a commit that I have added to my main branch for another commit. I have fixed the main branch that I have forked. I have added a new pr #6614 that resolves this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test