Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Product/File version in Windows executables #4108

Closed
wants to merge 2 commits into from

Conversation

ananyak19
Copy link

@ananyak19 ananyak19 commented Dec 13, 2022

Which problem is this PR solving?

Short description of the changes

@ananyak19 ananyak19 requested a review from a team as a code owner December 13, 2022 08:37
@ananyak19 ananyak19 requested a review from albertteoh December 13, 2022 08:37
@albertteoh
Copy link
Contributor

Can you please provide more details on the motivation behind this PR:

  • What specific problem is this trying to solve.
  • What is the final outcome of this change, e.g. what the windows explorer properties would look like for the jaeger exe.
  • How do you plan to manage version updates for each new release?
  • How can/should we incorporate this into our release process?

@yurishkuro
Copy link
Member

Yeah, this PR is not usable as is. Judging by the file names, this may have something to do with some of these tools:

But the files are supposed to be generated at build time, not checked in. What we would need instead:

  • a Makefile target to generate those files
  • if the tool is a Go program, it needs to be installed like the other build-time tools we install
  • It needs to use proper Jaeger icon
  • the config JSON needs to be filled out as appropriate for Jaeger project.
  • I am not clear if this will automatically use git tags for versions, or if we need to generate a different config file during build time where those values are populated (instead of 0.0.0.0)

@yurishkuro yurishkuro changed the title Pull request for setting version on jaeger binaries Set Product/File version in Windows executables Feb 3, 2023
@yurishkuro
Copy link
Member

closing as there was no follow-up, feel free to reopen if comments are addressed

@yurishkuro yurishkuro closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants