Product/File version in Windows executables

[pocki]

Requirement - what kind of business use case are you trying to solve?

Actual the windows executables (jaeger-agent.exe, jaeger-collector.exe, ...) don't have a version set. It is hard to identify the current used version and check if the actual used version is outdated.

Problem - what in Jaeger blocks you from solving the requirement?

Checking the actual used version and identity an outdated version.
We have some applications running native on Windows (Server) and therefore the agent is also running native on Windows.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Set the Product and/or File Version of the windows executables on compile or release.

Any open questions to address

[yurishkuro]

Jaeger binaries support "version" subcommand, is that not enough?

[pocki]

Thanks for the information. It's a little bit hidden.
Normally the services are always running and you just want to check the version.
On Windows users are more likely to check it the properties page instead of extra typing in a command and starting the subcommand (also when the parameter for version nearly every app uses different)

As addition to the subcommand the product/file version would be very nice to have

[yurishkuro]

I don't know if Go compiler supports setting these properties on the Windows binary, but I don't have any objections to including them.

[pocki]

Sorry, I am not familiar with Go and Go compiler.

[grammicus]

Hi can I take this?

[yurishkuro]

@smolgeat sure

[xmarcoied]

Hi @yurishkuro.

I don't know if Go compiler supports setting these properties on the Windows binary, but I don't have any objections to including them.

I don't think there's a straightforward way to apply such configurations with Go Compile. but I am thinking to use a 3rd party service/repo to embed such info through a go:generate. What do you think about this approach? I can draft a PR for one.

[yurishkuro]

That might be ok, I would recommend checking what other projects do (e.g. does Hugo have Windows binaries? Do they tag them like that?)

[keremgocen]

looking for a beginner-friendly issue if this is available

[yurishkuro]

it is

[ananyak19]

Hey can I work on this?

[yurishkuro]

Yes

[ananyak19]

/assign

[ananyak19]

Hi @pocki I am a first time contributor, can you please guide on how to get started here and where I need to make the changes in order to solve the issue?

[pocki]

As you can see above, I am also not familiar with Go and the Go Compiler.
Please check the contribution guidelines for this project.

[yurishkuro]

I see references to two utilities that seem to achieve this: https://stackoverflow.com/questions/35126344/how-to-set-the-file-version-field-in-pe-header-of-exe-files

[ananyak19]

Hi, @pocki @yurishkuro i tried to clone the repository but don't have the required access rights. Can you help me with that?

[yurishkuro]

you need to clone into your personal namespace, e.g. ananyak19/jaeger