Rearrange nav controls #676
Conversation
Signed-off-by: yoave23 <[email protected]>
yoave23
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 94.23% 94.23%
=======================================
Files 228 228
Lines 5930 5930
Branches 1448 1492 +44
=======================================
Hits 5588 5588
+ Misses 308 304 -4
- Partials 34 38 +4
Continue to review full report at Codecov.
|
| @@ -29,6 +29,8 @@ import { ConfigMenuItem, ConfigMenuGroup } from '../../types/config'; | |||
| import { getConfigValue } from '../../utils/config/get-config'; | |||
| import prefixUrl from '../../utils/prefix-url'; | |||
|
|
|||
| import JaegerHomeLink from '../../img/jaeger-home-link.svg'; | |||
There was a problem hiding this comment.
what is this for & why didn't we need it before?
There was a problem hiding this comment.
The upper left link looked like another tab, but the behavior is not the same as in tabs - there is no selected state nor content. We changed it to an image to make it clearer that it’s the ‘home’ link and that it differs from the controls next to it.
There was a problem hiding this comment.
Sounds good, but it seems we could've done it simply with a text label instead of an image?
If we go with an svg image, perhaps we could include the logo as well.
There was a problem hiding this comment.
your choice :)
this is how it looks with the logo (personally i don't like it that much):
on the other hand, we can go with a simple text label and a different font, just to distinguish it from the other controls
There was a problem hiding this comment.
Let's do a text label / different font.
| autosize={null} | ||
| name="idInput" | ||
| placeholder="Lookup by Trace ID..." | ||
| prefix={<Icon type="search" />} |
Signed-off-by: yoave23 <[email protected]>
|
kept the same font but changed the size and weight |
* Rearange nav controls Signed-off-by: yoave23 <[email protected]> * Remove logo and use text Signed-off-by: yoave23 <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
* Rearange nav controls Signed-off-by: yoave23 <[email protected]> * Remove logo and use text Signed-off-by: yoave23 <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
* Rearange nav controls Signed-off-by: yoave23 <[email protected]> * Remove logo and use text Signed-off-by: yoave23 <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Which problem is this PR solving?
Short description of the changes